feat: Add base for settings, and relocate venv-name default to it. #1509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocates the
.venv
default venv name into a settings file that can be customized.I couple of decisions I'm certain will end up getting questioned:
etcetera
preempts the moment where someone usesdirs
to implement settings and annoy all the macos users who dont want their settings to live inApplication Support/
. (Like all the other rust tools using dirs/dirs-next that end up getting issues reported against them).toml_edit
overtoml
. Mostly I'm just unfamiliar withtoml
and already have working code using toml-edit 😬 . Secondarily I figured long-term you'd probably implementuv init
oruv add
that will want to write toml, and you'll end up swapping totoml_edit
then anyways.If you're not ready to commit to specific settings, or otherwise already have a system (i.e. something from ruff) in mind that you'd want to replicate, feel free to close this. Rather than submitting an issue, I figured I could quickly do the thing I'd otherwise be requesting.
I didn't attempt to implement any tests in case this was quickly dead in the water.