-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log build output #2156
Log build output #2156
Conversation
ec88848
to
c0eb764
Compare
My gut is that this needs to be streamed in order to be useful, even though it makes it much more complex. Otherwise, it still feels like uv is hanging and you don't have clarity into what's going on or why. |
For the interactive use case, yes, 99% of the value is in streaming it. I do think there are some benefits to having it available for later review in contexts like CI logs, even if it's printed in batch. |
b6a0c27
to
84780b1
Compare
84780b1
to
0098da7
Compare
Can't this forward the TTY info? At least when streaming is supported, but it seems like it might make sense to do it correctly now? Scikit-build-core is careful to produce nicely colored output if printing to a console, and it works with |
The main challenge is that we build in parallel. We can't plain forward the output as a single tenant builder like scikit-build-core can, we need to somehow wrap them with context. I'd love to have something like |
IMO, |
FWIW, pip's model for local package builds is that it doesn't cache anything about them -- they get rebuilt + reinstalled on every run. |
Should be handled by #6903. |
Show source distribution build output in debug (
-v
) logging.Example output for
uv pip install --no-cache-dir --no-binary :all: -v tqdm 2> stderr.txt
: gist.I'd suggest taking hierarchical layer out of the default
-v
, i find the indentation makes it hard to read and the spans are generally not that informative compare to the actual log messages.I've also added anstream filtering to the log output after seeing ansi codes in my log files.
Fixes #2146
Partially addresses #1567 - It doesn't show output while compiling but only after. We can consider i meanwhile but this is a much larger project due to complexity around pipes.