Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write relative paths for scripts in data directory #2348

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

In #2000, I shipped a regression whereby we stopped writing relative paths for scripts within data directories. The net effect here is that we aren't uninstalling binaries in all cases. (This does not apply to entrypoints, only scripts in data directories.)

Closes #2330.

Test Plan

Most Python packages ship entrypoints, not binaries, so I don't know how to test this cheaply. But I did test it locally by verifying that uv is now removed from the bin directory after an uninstall.

@charliermarsh charliermarsh added the bug Something isn't working label Mar 10, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) March 10, 2024 22:55
@charliermarsh charliermarsh merged commit 9566ac9 into main Mar 10, 2024
7 checks passed
@charliermarsh charliermarsh deleted the charlie/rel branch March 10, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv pip uninstall uv does not remove the uv script from a venv
1 participant