-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix priority of ABI tags #2489
Merged
Merged
Fix priority of ABI tags #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef2c792
to
ec7d8cc
Compare
ec7d8cc
to
b325acd
Compare
I'd like to do some additional verification that changes are correct on other platforms too e.g. macOS |
charliermarsh
approved these changes
Mar 16, 2024
b325acd
to
313dd0c
Compare
zanieb
added a commit
that referenced
this pull request
Mar 16, 2024
# Conflicts: # crates/platform-tags/src/tags.rs # Conflicts: # crates/platform-tags/src/tags.rs
# Conflicts: # crates/platform-tags/src/tags.rs # Conflicts: # crates/platform-tags/src/tags.rs
…t version # Conflicts: # crates/platform-tags/src/tags.rs # Conflicts: # crates/platform-tags/src/tags.rs
# Conflicts: # crates/platform-tags/src/tags.rs
I've confirmed this is correct on macOS |
konstin
approved these changes
Mar 18, 2024
zanieb
added a commit
that referenced
this pull request
Mar 18, 2024
Following #2489 this is the last remaining difference from Python 3.12's packaging module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings us in-line with Python's behavior:
none
tags after all of the relevant platform tagsnone
tags for CPython versions less than the current versionpy3-none
) version tags over minor (i.e.py3x-none
) version tags less than the current versionnone-any
tag for the current CPython versionTest plan
Tested on my Linux machine with a script to emit tags at the desired glibc version:
Then performed a diff with the snapshot in
tags.rs