Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel builds and uploads for musl ARM #2518

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix wheel builds and uploads for musl ARM #2518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cccfbc9
Fix wheel builds and uploads for musl ARM
charliermarsh Mar 18, 2024
161dc43
Keep arm
charliermarsh Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,6 @@ jobs:
maturin_docker_options: -e JEMALLOC_SYS_WITH_LG_PAGE=16
- target: armv7-unknown-linux-gnueabihf
arch: armv7
- target: armv7-unknown-linux-musleabihf
arch: armv7
- target: arm-unknown-linux-musleabihf
arch: arm

Expand Down Expand Up @@ -306,8 +304,6 @@ jobs:
pip3 install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall
${{ env.MODULE_NAME }} --help
- name: "Upload wheels"
# Skip for `arm`, which is not supported by PyPI.
if: ${{ matrix.platform.arch != 'arm' }}
uses: actions/upload-artifact@v4
with:
name: wheels-${{ matrix.platform.target }}
Expand Down Expand Up @@ -540,6 +536,8 @@ jobs:
- target: aarch64-unknown-linux-musl
arch: aarch64
maturin_docker_options: -e JEMALLOC_SYS_WITH_LG_PAGE=16
- target: armv7-unknown-linux-musleabihf
arch: armv7

steps:
- uses: actions/checkout@v4
Expand Down
Loading