-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UV_CUSTOM_COMPILE_COMMAND support to uv pip compile #2554
Add UV_CUSTOM_COMPILE_COMMAND support to uv pip compile #2554
Conversation
cmd( | ||
include_index_url, | ||
include_find_links, | ||
custom_compile_command | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, if you prefer to have it inline:
cmd( | |
include_index_url, | |
include_find_links, | |
custom_compile_command | |
) | |
custom_compile_command.unwrap_or(cmd(include_index_url, include_find_links)) |
and revert the changes in cmd
function
fn cmd( | ||
include_index_url: bool, | ||
include_find_links: bool, | ||
custom_compile_command: Option<String>, | ||
) -> String { | ||
if let Some(cmd_str) = custom_compile_command { | ||
return cmd_str; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If above suggestion, revert
fn cmd( | |
include_index_url: bool, | |
include_find_links: bool, | |
custom_compile_command: Option<String>, | |
) -> String { | |
if let Some(cmd_str) = custom_compile_command { | |
return cmd_str; | |
} | |
fn cmd(include_index_url: bool, include_find_links: bool) -> String { |
Co-authored-by: Hans Baker <hansbaker90@gmail.com>
Co-authored-by: Hans Baker <hansbaker90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This adds |
(I read the release notes, then couldn't figure out why |
Thanks, i updated the release notes. |
Summary
This adds support for
CUSTOM_COMPILE_COMMAND
support to change the header comment in generated requirements files.See Issue:
From pip-tools docs:
Test Plan
See unit test included