Add support for unnamed local directory requirements #2571
Conversation
charliermarsh
force-pushed
the
charlie/bare-iii
branch
4 times, most recently
from
77611ea to
81e1ded
Compare
| // Attempt to read a `setup.py` from the directory. | ||
| if let Ok(setup_py) = fs_err::read_to_string(path.join("setup.py")) { | ||
| static SETUP_PY_NAME: Lazy<Regex> = | ||
| Lazy::new(|| Regex::new(r#"name\s*[=:]\s*['"](?P<name>[^'"]+)['"]"#).unwrap()); |
There was a problem hiding this comment.
\cc @BurntSushi - Here I want to match setup(name="foo")-like calls.
There was a problem hiding this comment.
I do not think frontends are supposed to use build backend–specific heuristics to retrieve metadata.
There was a problem hiding this comment.
I'm fine with it. These are just heuristics to support non-spec compliant requirement definitions.
There was a problem hiding this comment.
Why not run prepare_metadata_for_build_wheel() and use the metadata from there like pip does?
There was a problem hiding this comment.
I don't want to pay that cost here when all we need is the project name (which is far less to ask than the project metadata). I'll consider it though.
There was a problem hiding this comment.
I'll look into how challenging it would be.
There was a problem hiding this comment.
The project name is part of the Core metadata spec just like Requires-Dist or anything else, but I understand. Thanks for looking into it.
There was a problem hiding this comment.
Also, it's possible for a build backend to exist that isn't setuptools or poetry and doesn't use PEP 621 metadata.
charliermarsh
force-pushed
the
charlie/bare-ii
branch
from
c5e8a94 to
2d5f4df
Compare
charliermarsh
force-pushed
the
charlie/bare-iii
branch
from
81e1ded to
aac789c
Compare
charliermarsh
added
the
enhancement
charliermarsh
force-pushed
the
charlie/bare-ii
branch
from
2d5f4df to
2c9c748
Compare
charliermarsh
force-pushed
the
charlie/bare-iii
branch
from
aac789c to
6e118c9
Compare
charliermarsh
force-pushed
the
charlie/bare-ii
branch
from
2c9c748 to
b2ad283
Compare
charliermarsh
force-pushed
the
charlie/bare-iii
branch
from
6e118c9 to
87b4a1e
Compare
Summary
For example:
cargo run pip install .The strategy taken here is to attempt to extract the package name from the distribution without executing the PEP 517 build steps. We could choose to do that in the future if this proves lacking, but it adds complexity.
Part of: #313.