Ignore direct URL distributions in prefetcher #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Apr 9, 2024
| @@ -52,7 +52,7 @@ impl BatchPrefetcher { | |||
| index: &InMemoryIndex, | |||
| selector: &CandidateSelector, | |||
| ) -> anyhow::Result<(), ResolveError> { | |||
| let PubGrubPackage::Package(package_name, _, _) = &next else { | |||
| let PubGrubPackage::Package(package_name, None, None) = &next else { | |||
There was a problem hiding this comment.
If we include an extra, we'll also include the non-extra variant in the tree. So it seems fine to confine this to those non-extra variants, rather than duplicating the prefetch.
|
Confirming in #2942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The prefetcher tallies the number of times we tried a given package, and then once we hit a threshold, grabs the version map, assuming it's already been fetched. For direct URL distributions, though, we don't have a version map! And there's no need to prefetch.
Closes #2941.