Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorities for editables #3133

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add priorities for editables #3133

merged 1 commit into from
Apr 19, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Apr 19, 2024

Summary

We weren't setting a priority for editables, so they were being visited last.

I think there's still a problem whereby we're not aggressive enough in visiting recursive extras (and, in fact, that's making it really hard to write a test -- I wrote a test, but the most-reduced case still fails, and I'd need to add a layer of indirection to make it fail-on-main-but-pass-on-this-branch), but that problem likely already existed on main prior to #3087, so I just want to get this quick fix out now.

Closes #3127.

Test Plan

  • git clone https://github.com/cda-tum/mqt-core.git
  • cargo run venv
  • cargo run pip install 'scikit-build-core[pyproject]>=0.8.1' 'setuptools_scm>=7' 'pybind11>=2.12' --resolution=lowest-direct
  • cargo run pip install --no-build-isolation '-ve.[test,qiskit,evaluation,coverage]' --resolution=lowest-direct

@charliermarsh charliermarsh marked this pull request as ready for review April 19, 2024 01:54
@charliermarsh charliermarsh added the bug Something isn't working label Apr 19, 2024
@charliermarsh
Copy link
Member Author

I plan to follow-up with another fix and a real test.

@charliermarsh charliermarsh enabled auto-merge (squash) April 19, 2024 01:57
@charliermarsh charliermarsh merged commit a241bc7 into main Apr 19, 2024
38 checks passed
@charliermarsh charliermarsh deleted the charlie/ed branch April 19, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency resolution regression in 0.1.33
1 participant