Add alternate manylinux targets to --python-platform
#3229
Conversation
charliermarsh
added
the
enhancement
charliermarsh
changed the title
--python-platform
charliermarsh
force-pushed
the
charlie/many
branch
from
c110083 to
bab82b8
Compare
charliermarsh
force-pushed
the
charlie/many
branch
from
bab82b8 to
4020ef1
Compare
| @@ -27,7 +27,7 @@ pub enum TargetTriple { | |||
| #[cfg_attr(feature = "clap", value(name = "x86_64-pc-windows-msvc"))] | |||
| X8664PcWindowsMsvc, | |||
|
|
|||
| /// An x86 Linux target. | |||
| /// An x86 Linux target. Equivalent to `x86_64-manylinux_2_17`. | |||
| #[cfg_attr(feature = "clap", value(name = "x86_64-unknown-linux-gnu"))] | |||
| X8664UnknownLinuxGnu, | |||
There was a problem hiding this comment.
We could consider removing these and only supporting the manylinux versions? And change x86_64-unknown-linux-musl to x86_64-musllinx_1_2?
They used to also provide docker images for 2_24, while it's deprecated now they are still some packages targeting it. BTW, some manylinux policies do not have official docker images probably because the version is new enough to just build on a recent Ubuntu system. See also |
|
I saw at least one package that publishes at 2_27, but even in that case it seems reasonable to just expose 2_28, ie, have some coarseness in the setting. We can always expand support in the future. |
Summary
I initially implemented this by allowing arbitrary
x86_64-manylinux_x_y, but it makes the Clap, Serde, and Schemars definitions more complicated, and makes it harder for the user. Ultimately, manylinux itself only provides images for 2_17 and 2_28, so this seems like it should be sufficient.Closes #3222.