Disable concurrent progress bars in Jupyter Notebooks #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
force-pushed
the
jupyter-progress
branch
from
dafba44
to
93ca4b9
Compare
ibraheemdev
commented
May 28, 2024
| @@ -201,6 +266,9 @@ impl uv_installer::DownloadReporter for DownloadReporter { | |||
| } | |||
|
|
|||
| fn on_complete(&self) { | |||
| // Need an extra call to `set_message` here to fully clear avoid leaving ghost output | |||
| // in Jupyter notebooks. | |||
| self.reporter.root.set_message(""); | |||
There was a problem hiding this comment.
This bug existed before the new progress bars, where if the previous progress bar line was longer than the next one, it wouldn't be fully cleared. Seems like a bug in indicatif.
|
Can you also test this in Jupyter Lab? Same process but run |
charliermarsh
approved these changes
May 28, 2024
CodSpeed Performance ReportMerging #3890 will improve performances by 6.72%Comparing Summary
Benchmarks breakdown
|
|
@charliermarsh seems to work there too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3887 by disabling the new progress output when the
JPY_SESSION_NAMEenvironment variable is detected.Test Plan
Fixed output in a Jupyter notebook: