Avoid showing dev hints for Python requirements #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/dev-hint
branch
from
05de804
to
93719f5
Compare
charliermarsh
commented
Jun 6, 2024
| version: version.clone(), | ||
| }); | ||
| if let PubGrubPackageInner::Package { name, .. } = &**package { | ||
| // Check for no versions due to pre-release options |
There was a problem hiding this comment.
The whole body is now just indented under if let PubGrubPackageInner::Package { name, .. } = &**package. Unfortunately we can't do this in the match itself because of the inner struct.
charliermarsh
commented
Jun 6, 2024
| return false; | ||
| }; | ||
| selector.prerelease_strategy().allows(name) | ||
| } |
There was a problem hiding this comment.
Not really necessary anymore, we just inline selector.prerelease_strategy().allows(name) because we have the name already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4096.