feat: mTLS support #4171
Merged
feat: mTLS support #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see I think we could explore support via config file in a future PR if it makes sense for uv to do so, thoughts? |
|
Thanks for putting this up!
Totally fine with me to separate the implementation |
zanieb
reviewed
Jun 10, 2024
zanieb
reviewed
Jun 10, 2024
zanieb
approved these changes
Jun 10, 2024
zanieb
added
the
enhancement
samypr100
force-pushed
the
mutual-tls
branch
3 times, most recently
from
f17b828 to
a48b9a1
Compare
zanieb
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3626
This adds mTLS support to uv via the standard env var
SSL_CLIENT_CERT.Test Plan
Tested locally using a nginx proxy to pypi using my own self-signed ca + certs + client certs generated via mkcert. Used this proxy with both uv and pip to make sure we have feature partity in mTLS functionality.