Create member pyproject.toml prior to workspace discovery
#5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/add
branch
from
a2ff3db to
99e2b98
Compare
charliermarsh
changed the title
init directory prior to workspace discoverypyproject.toml prior to workspace discovery
charliermarsh
force-pushed
the
charlie/add
branch
from
99e2b98 to
c6316aa
Compare
zanieb
reviewed
Jul 23, 2024
| assert_snapshot!( | ||
| workspace, @r###" | ||
| [tool.uv.workspace] | ||
| members = ['packages/*', "packages/foo"] |
There was a problem hiding this comment.
To clarify, we want to add a specific entry even though it's already covered?
There was a problem hiding this comment.
Nope! That's a bug. Already exists prior to this PR.
There was a problem hiding this comment.
(I'm already fixing it separately, it's how I discovered the bug fixed in this PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise, if the path is already a member, discovery fails.
Also adds a failing test for "adding members that are already covered by
members".