Replace --python-preference installed with managed
#5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/python-managed
branch
2 times, most recently
from
8315b03 to
4a170cd
Compare
zanieb
force-pushed
the
zb/python-managed
branch
from
4a170cd to
7777f49
Compare
Collapses the previous default into "managed" and makes the "managed" behavior match "installed". People should use "only-managed" if they want that behavior, it seems overly complicated otherwise.
zanieb
force-pushed
the
zb/python-managed
branch
from
7777f49 to
3cffc0b
Compare
charliermarsh
approved these changes
Jul 31, 2024
|
Thanks for giving it a look :) |
This was referenced Aug 3, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Aug 3, 2024
….md (#5755) ## Summary After referring to #5637 and doing additional testing. The default value in a stable state seems more reasonable to be ``only-system``. ``managed`` in preview. ``` cpython-3.11.9-windows-x86_64-none C:\Users\name\AppData\Local\Programs\Python\Python311\python.exe cpython-3.10.14-windows-x86_64-none C:\Users\name\AppData\Roaming\uv\data\python\cpython-3.10.14-windows-x86_64-none\install\python.exe cpython-3.10.11-windows-x86_64-none C:\Users\name\AppData\Local\Programs\Python\Python310\python.exe cpython-3.9.19-windows-x86_64-none C:\Users\name\AppData\Roaming\uv\data\python\cpython-3.9.19-windows-x86_64-none\python.exe ``` test on uv 0.2.33 (build from https://github.com/astral-sh/uv/tree/257007ccaf0912a41dfe91b534527a7b1f54e19a) ### Stable version ``uv venv -p 3.10`` is ``3.10.11`` (System Python) ``uv venv -p 3.9`` is ``No interpreter found``(3.9.19 for managed Python) ``uv venv -p 3.9 --python-preference only-system`` is ``No interpreter found``(fail) ``uv venv -p 3.9 --python-preference only-managed`` is ``3.9.19``(success) Do not use managed Python, only use the system Python, so it can be determined as ``only-system``. ### Preview mode **Note:** ``3.10.14`` is managed python, ``3.10.11`` is system python. ``uv venv -p 3.11 --preview`` is ``3.11.9`` (System Python) ``uv venv -p 3.10 --preview`` is ``3.10.14`` ``uv venv -p 3.10 --preview --python-preference only-managed`` is ``3.10.14`` ``uv venv -p 3.10 --preview --python-preference managed`` is ``3.10.14`` ``uv venv -p 3.10 --preview --python-preference system`` is ``3.10.11`` ``venv -p 3.10 --preview --python-preference only-system`` is ``3.10.11`` Prioritize the managed Python and then select the system Python, so it can be determined as ``managed``. ----- fixed #5754 ## Test Plan Run website in local. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapses the previous default into "managed" and makes the "managed" behavior match "installed". People should use "only-managed" if they want that behavior, it seems overly complicated otherwise.