cargo: straighten out LTO configuration #5955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the change made in #5904 so that the
profiling
Cargoprofile does not have LTO enabled. With LTO enabled, compile times
even after just doing a
touch crates/uv/src/bin/uv.rs
are devastating:Even with
lto = "thin"
, compile times are not great, but animprovement:
But our original configuration for
profiling
, prior to #5904, was withLTO completely disabled:
This gives reasonable-ish compile times, although I still want them to
be better.
This setup does risk that we are measuring something in benchmarks that
we are shipping, but in order to make those two the same, we'd either
need to make compile times way worse for development, or take a hit
to binary size and a slight hit to runtime performance in our release
builds. I would weakly prefer that we accept the hit to runtime
performance and binary size in order to bring our measurements in line
with what we ship, but I strongly feel that we should not have compile
times exceeding minutes for development. When doing performance testing,
long compile times, for me anyway, break "flow" state.
A confounding factor here was that #5904 enabled LTO for the
release
profile, but the
dist
profile (used bycargo dist
) was still settingit to
lto = "thin"
. However, because of shenanigans in our releasepipeline, we we actually using the
release
profile for binaries weship. This PR does not make any changes here other than to remove
lto = "thin"
from thedist
profile to make the fact that they are the samea bit clearer.
cc @davfsa