Extract METADATA reading into a crate #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
force-pushed
the
konsti/split-out-uv-metadata
branch
4 times, most recently
from
90d43a4
to
9270c60
Compare
charliermarsh
approved these changes
Sep 9, 2024
This is preparatory work for the upload functionality, which needs to read the METADATA file and attach its parsed contents to the POST request: We move finding the `.dist-info` from `install-wheel-rs` and `uv-client` to a new `uv-metadata` crate, so it can be shared with the publish crate. This isn't properly ready since the upload code isn't ready, but i'm PR-ing it now because it already had merge conflicts.
konstin
force-pushed
the
konsti/split-out-uv-metadata
branch
from
9270c60
to
3e76d77
Compare
konstin
commented
Sep 10, 2024
Comment on lines
-2622
to
+2626
| error: Failed to read `foo @ file://[TEMP_DIR]/foo-1.2.3-not-compatible-wheel.whl` | ||
| Caused by: Failed to unzip wheel: foo-1.2.3-not-compatible-wheel.whl | ||
| Caused by: unable to locate the end of central directory record | ||
| × No solution found when resolving dependencies: | ||
| ╰─▶ Because foo has an invalid package format and you require foo, we can conclude that your requirements are unsatisfiable. | ||
|
|
||
| hint: The structure of foo was invalid: | ||
| Failed to read from zip file |
There was a problem hiding this comment.
This is a regression from the pervious error message, but fixing it requires propagating changes through a bunch of error types so i'll be following up next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparatory work for the upload functionality, which needs to read the METADATA file and attach its parsed contents to the POST request: We move finding the
.dist-infofrominstall-wheel-rsanduv-clientto a newuv-metadatacrate, so it can be shared with the publish crate.I don't properly know if its the right place since the upload code isn't ready, but i'm PR-ing it now because it already had merge conflicts.