Perform source distribution builds in archive directory #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
windows
|
This is just something to help right? Not the "real" long term fix? |
Sorry, what would this be? There's a fundamental path length limit. All we can do is help, I don't think there is a real fix. |
|
I was thinking about how we previously talked about using a hash instead of a wheel file name in the cache. Looking at the linked issue I see this looks like a separate file length issue than that though. |
|
Oh sorry, yes! That's a separate issue, I don't think this will help with that sadly. |
|
No problem I should have looked at the issue or read more closely. Thanks for clarifying! |
charliermarsh
force-pushed
the
charlie/build-cache
branch
5 times, most recently
from
5381947 to
070290f
Compare
charliermarsh
force-pushed
the
charlie/build-cache
branch
from
070290f to
6512b04
Compare
charliermarsh
force-pushed
the
charlie/build-cache
branch
from
6512b04 to
dc7e0da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to help with #7078 by reducing the length of cache paths on Windows. It needs some testing on my Windows machine though.