Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bump mechanism (mostly ported from rye) #7248

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

nrbnlulu
Copy link

@nrbnlulu nrbnlulu commented Sep 10, 2024

Summary

Implement bump mechanism following major.minor.patch format.
fix #6298

I chose the bump name since version is already used though I would consider removing the current version handler for this

Test Plan

Simple idiomatic tests modifying the test pyprojec and checking the output statically

@nrbnlulu nrbnlulu marked this pull request as ready for review September 11, 2024 10:52
@nrbnlulu
Copy link
Author

windows test is failing though it seems more like a flaky test rather than something related to my changes...

@charliermarsh charliermarsh added the enhancement New feature or improvement to existing functionality label Sep 11, 2024
@zanieb
Copy link
Member

zanieb commented Sep 15, 2024

I'll review this. We'll need to consider what version management interface we want in the long run.

@ThirVondukr
Copy link

PEP440 https://peps.python.org/pep-0440/
and commitizen config https://commitizen-tools.github.io/commitizen/commands/bump/#version_scheme
could be good reference points

@zanieb
Copy link
Member

zanieb commented Oct 6, 2024

I still haven't had time to decide if we want to replace uv version for this.

@nrbnlulu
Copy link
Author

nrbnlulu commented Oct 13, 2024

Is this PR wanted? should I resolve conflicts?

@n4z4m3
Copy link

n4z4m3 commented Nov 11, 2024

Is this PR wanted? should I resolve conflicts?

I would find this useful, but I see there has been no action on this for a while. Currently I use bump-my-version to do this, but it would be great to have it built into uv.

@nrbnlulu
Copy link
Author

yeah. the maintainers said they want to inspect other project \ alternative interfaces to have better context on this feature.
if someone is interested doing the research it would be cool.

@mthipparthi
Copy link

This is great feature and removes the dependency on bump version. This one along with change-log generation makes this tool complete.

@zanieb
Copy link
Member

zanieb commented Nov 27, 2024

I think about this pretty often, but I'm still not quite sure what to do, e.g., cargo version is not used for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command to read and update (i.e., bump) the project version, e.g., uv version
6 participants