Disable color output when redirecting stderr #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm still confused about it, but this seems to do the right thing? Test command, ran with network deactivated: ```shell RUST_LOG=debug cargo run --bin puffin -- pip-compile -v ./scripts/popular_packages/pypi_8k_downloads.txt 2> log.txt ``` **Before** ``` �[1;31merror�[0m: Request error: error sending request for url (https://pypi.org/simple/apache-airflow-providers-dbt-cloud/): error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution �[1;31mCaused by�[0m: error sending request for url (https://pypi.org/simple/apache-airflow-providers-dbt-cloud/): error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution �[1;31mCaused by�[0m: error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution �[1;31mCaused by�[0m: dns error: failed to lookup address information: Temporary failure in name resolution �[1;31mCaused by�[0m: failed to lookup address information: Temporary failure in name resolution ``` **After** ``` error: Request error: error sending request for url (https://pypi.org/simple/fissix/): error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: error sending request for url (https://pypi.org/simple/fissix/): error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: dns error: failed to lookup address information: Temporary failure in name resolution Caused by: failed to lookup address information: Temporary failure in name resolution ```
|
Can we find a way to do this with anstream? |
BurntSushi
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
I'm fine with this if it fixes the issue, but from a quick look at puffin's dependencies, it seems like we're using no fewer than three different terminal coloring libraries? (I see anstream, colored and nu-ansi-term.) It'd be nice to fix that, and I agree that we should pick anstream.
charliermarsh
added a commit
that referenced
this pull request
Jan 7, 2024
## Summary We can use `anstream` for all color control, rather than going through `colored`. Note that we still need the `colored` crate, since `colored` and `anstream` solve different problems. (`anstream` recommends using `owo-colors` alongside it, but `colored` seems to work fine?) Resolves the issue raised in #742 via `anstream` rather than `colored`. Closes #782.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still confused about it, but this seems to do the right thing?
HierarchicalLayerinternally haslet ansi = io::stderr().is_terminal();, so the logging itself is already correctly uncolored, but errors in the log weren't.Test command, ran with network deactivated:
RUST_LOG=debug cargo run --bin puffin -- pip-compile -v ./scripts/popular_packages/pypi_8k_downloads.txt 2> log.txtBefore
After