Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PythonRequest::Any -> PythonRequest::Default #7514

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Sep 18, 2024

As we support more complex Python discovery behaviors such as:

Any is no longer accurate, we actually are looking for a reasonable default Python version to use which may exclude the first one we find. Separately, we need the idea of Any to improve behavior when listing versions (e.g., #7286) where we do actually want to match any Python version. As a first step, we'll rename Any to Default. Then, we'll introduce a new Any that actually behaves as we'd expect.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Sep 18, 2024
@zanieb zanieb marked this pull request as ready for review September 18, 2024 19:47
@zanieb zanieb merged commit 5941709 into main Sep 19, 2024
59 checks passed
@zanieb zanieb deleted the zb/python-request-all branch September 19, 2024 10:56
zanieb added a commit that referenced this pull request Sep 19, 2024
zanieb added a commit that referenced this pull request Sep 19, 2024
Follow-up to #7514 and #7526 adding
the `Any` variants again with slightly different semantics (i.e., they
allow pre-releases)

We'll be able to use this in #7508
to avoid querying a bunch of alternative interpreters unnecessarily in
the non-list case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants