Add --group support to uv add and uv remove
#8108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/735-add
branch
2 times, most recently
from
a94726f to
9d0e1e0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
zanieb
force-pushed
the
zb/735-add
branch
4 times, most recently
from
47fdf22 to
fc36784
Compare
zanieb
commented
Oct 15, 2024
zanieb
force-pushed
the
zb/735-add
branch
2 times, most recently
from
1c476cd to
89efa56
Compare
charliermarsh
approved these changes
Oct 16, 2024
| @@ -190,6 +217,49 @@ impl From<Metadata> for RequiresDist { | |||
| } | |||
| } | |||
|
|
|||
| fn apply_source_strategy( | |||
There was a problem hiding this comment.
I was somewhat surprised that this is only used once. I guess the other "dependency types" (like production) don't match this exact pattern?
There was a problem hiding this comment.
Yeah I actually moved it out because I thought I would need to apply it twice, like.. to the dev-dependencies group but I ended up structuring things differently. I think we can move it back in, or make it an impl method somewhere.
| }) | ||
| .collect::<Result<Vec<_>, _>>()?; | ||
|
|
||
| dependency_groups.into_iter().collect::<BTreeMap<_, _>>() |
There was a problem hiding this comment.
Does this correctly merge keys? Like if dev is included twice, does this concatenate the values? I sort of think it might replace them...
There was a problem hiding this comment.
I think it probably replaces them, yeah. I wasn't a goal to resolve that here (per the description) since this implemented before I wrote a proposal. I figured I'd write some test cases and address it separately for review purposes.
Merged
zanieb
added a commit
that referenced
this pull request
Oct 18, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 20, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 22, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 23, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
charliermarsh
pushed a commit
that referenced
this pull request
Oct 25, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
zanieb
added a commit
that referenced
this pull request
Oct 25, 2024
Part of #8090 Adds the ability to add and remove dependencies from arbitrary groups using `uv add` and `uv remove`. Does not include resolving with the new dependencies — tackling that in #8110. Additionally, this does not yet resolve interactions with the existing `dev` group — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8090
Adds the ability to add and remove dependencies from arbitrary groups using
uv addanduv remove. Does not include resolving with the new dependencies — tackling that in #8110.Additionally, this does not yet resolve interactions with the existing
devgroup — we'll tackle that separately as well. I probably won't merge the stack until that design is resolved.