Simplify pip tree tests to improve performance
#8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Oct 29, 2024
|
|
||
| #[test] | ||
| #[cfg(target_os = "macos")] | ||
| fn complex_nested_dependencies_inverted() { |
There was a problem hiding this comment.
I don't think these "complex" tests are worth it. We have to install the whole tree here, and they aren't testing any new behavior.
charliermarsh
force-pushed
the
charlie/tree
branch
from
223d065 to
80e2259
Compare
charliermarsh
force-pushed
the
charlie/tree
branch
from
80e2259 to
b99f118
Compare
zanieb
approved these changes
Oct 29, 2024
charliermarsh
force-pushed
the
charlie/tree
branch
2 times, most recently
from
89e035b to
2d62a6c
Compare
charliermarsh
force-pushed
the
charlie/tree
branch
from
2d62a6c to
b944f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These use really heavy test packages, like SciPy, NumPy, scikit-learn -- and packages with large dependency trees, like packse.
I removed a few redundant tests, and replaced the tests with smaller packages.
Closes #8674.