Align tempfile workspace dependencies with root project #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coruscant11
force-pushed
the
adjust-tempfile-dependency
branch
from
7bd5ba2 to
40550f5
Compare
Coruscant11
changed the title
charliermarsh
added
the
internal
This was referenced Nov 29, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Dec 1, 2024
…9555) ## Summary After #9524, I noticed two other dependencies were misaligned. Since the previous PR has been merged, I was thinking I could submit those two misses. Of course, open to any comments/decline! Thanks!! 🙂 ## Test Plan All units tests are still passing on my side. Let's see with the pull-request CI again 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on potential bug fixes with temporary files on Windows (I think I am currently ecountering the same issue as #2810)
I noticed that sub-workspaces were not all having the same
tempfileversion. And they were not relying on the cargo root project dependency. I don't know at all if it was done on purpose or not.(I also wanted to override the root dependency with a local source but it was not possible due to sub-workspaces not relying on the same).
The root lockfile already pinned to the
3.14.0. Some sub-workspaces were depending on the3.12.0, some others on the3.14.0. So I updated the rootCargo.tomlto the3.14.0.Feel free to decline if it was done on purpose! No worries at all 🙂
Thanks!
Test Plan
All units tests are still passing on my side. Let's see with the pull-request CI 😄