Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support bech32 addresses #30

Merged
merged 5 commits into from
Jun 27, 2024
Merged

feat: support bech32 addresses #30

merged 5 commits into from
Jun 27, 2024

Conversation

joroshiba
Copy link
Member

No description provided.

@joroshiba joroshiba marked this pull request as ready for review June 18, 2024 14:54
Base automatically changed from bharath/update-to-1.14 to main June 20, 2024 15:58
noot
noot reviewed Jun 26, 2024
View reviewed changes
params/config.go Outdated Show resolved Hide resolved
noot
noot reviewed Jun 26, 2024
View reviewed changes
params/config.go Show resolved Hide resolved
bharath-123
bharath-123 reviewed Jun 26, 2024
View reviewed changes
grpc/execution/validation_test.go
func generateBech32MAddress() string {
addressKey, err := crypto.GenerateKey()
if err != nil {
panic(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of panicking, we can return an error and throw a t.Fatal where we use this method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this will ever happen, copied how we behave elsewhere in the tests when generating a key

@joroshiba joroshiba merged commit 082e84f into main Jun 27, 2024
2 checks passed
@joroshiba joroshiba deleted the bech32m branch June 27, 2024 18:12
steezeburger added a commit that referenced this pull request Jul 9, 2024
@steezeburger
Merge branch 'main' into local-dev
956c915 
* main:
  fix: update with new asset proto (#34)
  feat: support bech32 addresses (#30)
  fix: Ensure all txs are removed from mempool when block building is interrupted (#29)
  disallow users from sending deposit txs and blob txs via the rpc (#24)
  Update Astria-geth to use geth 1.14.3 (#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot left review comments

@bharath-123 bharath-123 bharath-123 approved these changes

@mycodecrafting mycodecrafting Awaiting requested review from mycodecrafting mycodecrafting is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joroshiba @bharath-123 @noot