Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a single constructor for the sequencer gRPC client #1315

Closed
SuperFluffy opened this issue Jul 30, 2024 · 0 comments · Fixed by #1510
Closed

Have a single constructor for the sequencer gRPC client #1315

SuperFluffy opened this issue Jul 30, 2024 · 0 comments · Fixed by #1510
Labels
bridge-withdrawer code touching the bridge-withdrawer service code-quality

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Jul 30, 2024 •
edited by sync-by-unito bot
Loading

#1310 ran into the issue of astria-bridge-withdrawer hardcoding the URL scheme as http and subsequently fixed it to unblock the blackbox tests.

The client should ideally be created at a single point and passed into its consumers by cloneing it.

┆Issue Number: ENG-661
@SuperFluffy SuperFluffy added code-quality bridge-withdrawer code touching the bridge-withdrawer service labels Jul 30, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Sep 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 18, 2024
@ethanoroshiba
chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers…
f7ef132 
… directly (#1510)

## Summary
Changed `sequencer_cometbft_client` and `sequencer_grpc_client`
construction so that each can be passed to consumers via cloning.

## Background
Both clients were previously constructed ad-hoc from endpoints, which
was unnecessary.

## Changes
- Moved construction of `sequencer_cometbft_client` and
`sequencer_grpc_client` up so that each can be passed to its consumers
(`Startup` and `Submitter`) via cloning.

## Testing
Passing all tests

## Related Issues
closes #1315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bridge-withdrawer code touching the bridge-withdrawer service code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly astriaorg/astria
1 participant
@SuperFluffy