Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Trusted Builder MVP #1322

Closed
bharath-123 opened this issue Jul 31, 2024 · 2 comments
Closed

feat: Trusted Builder MVP #1322

bharath-123 opened this issue Jul 31, 2024 · 2 comments
Assignees
@bharath-123
Labels
closed-stale composer pertaining to composer conductor pertaining to the astria-conductor crate ENG-626 epic Larger scoped issues with many tasks evm pertains to EVM stale

Comments

@bharath-123
Copy link
Contributor

bharath-123 commented Jul 31, 2024 •
edited by sync-by-unito bot
Loading

This issue tracks the progress and the work required to build the trusted builder MVP

### Design work
- [x] Write a design doc: https://www.notion.so/astria-org/Trusted-Block-Builder-MVP-8eba7cd7cbd34e4e90a4adf726879028?pvs=4

### Astria-Geth changes
- [x] Support returning the included transactions as per the new protobuf changes for ExecuteBlock
- [x] Support simulateOnly mode for ExecuteBlock where we only create a block but do not insert it to the chain
- [x] Support validating BuilderBundlePacket
- [ ] Support validating BuilderBundlePacket signatures
- [x] Support moving transactions deserialized from BuilderBundlePacket to the top of block

### Composer changes
- [x] Support calling GetCommitmentState
- [x] Support calling ExecuteBlock on the final bundle to be submitted to simulate it
- [x] Support creating the BuilderBundlePacket
- [] Support signing of BuilderBundlePacket
- [x] Support sending the BuilderBundlePacket as a sequence action to sequencer
- [ ] Compute the max bytes of seq actions we can send based on the BuilderBundlePacket fields
- [x] Update blackbox tests of composer to call the execution api.

### Conductor Changes
- [x] Modify conductor to ensure that it is compatible with the new ExecutionAPI protobuf changes
- [x] Fix the unit tests in conductor post the protobuf changes.

### Protobuf changes
- [x] Modify ExecuteBlock protobuf to return the included transactions
- [x] Modify ExecuteBlock protobuf to accept a simulateOnly flag which will allow us to only create a block but not add it to the chain
- [x] Create the BuilderBundlePacket protobufs
- [x] Ensure that the Execution API protobuf changes and BuilderBundlePacket protobuf changes are pushed to buf.build

### Testing
- [x] Test if Astria Geth and Conductor compatible with the Execution API changes by deploying them locally
- [x] Launch the changes in a local cluster and send txs with spamooor

┆Issue Number: ENG-671
@bharath-123 bharath-123 added conductor pertaining to the astria-conductor crate evm pertains to EVM composer pertaining to composer epic Larger scoped issues with many tasks ENG-626 labels Jul 31, 2024
@bharath-123 bharath-123 self-assigned this Aug 1, 2024
@bharath-123 bharath-123 mentioned this issue Aug 13, 2024
Closed
@noot noot mentioned this issue Sep 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 7, 2024
@noot
refactor(sequencer): generate SequencerBlock after transaction exec…
f4dba95 
…ution in proposal phase (#1562)

## Summary
refactor the sequencer app to generate and store the resulting
`SequencerBlock` after transaction execution even in the proposal phase.

## Background
previously, we were only generating the `SequencerBlock` in
`finalize_block`, however with the upcoming builder APIs (#1519) we
require the (proposed) `SequencerBlock` to be available after execution
in the proposal phase.

## Changes
- create a `post_execute_transactions` method and move the
after-execution logic that generates the `SequencerBlock` from
`finalize_block` to there.
- call this method after transaction execution in `process_proposal`. 
- if txs were executed in `prepare_proposal`,
`post_execute_transactions` is still called in `process_proposal`, as
the block hash is not available in `prepare_proposal`.

## Testing
existing unit tests pass, app logic was not changed, just refactored

## Related Issues
 related to #1322
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba
Copy link
Member

This issue was closed because it was stale

@joroshiba joroshiba closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharath-123 bharath-123

Labels
closed-stale composer pertaining to composer conductor pertaining to the astria-conductor crate ENG-626 epic Larger scoped issues with many tasks evm pertains to EVM stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joroshiba @bharath-123