Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(ci): bridge withdrawer images not built with tag #1373

Closed
joroshiba opened this issue Aug 15, 2024 · 0 comments · Fixed by #1374
Closed

bug(ci): bridge withdrawer images not built with tag #1373

joroshiba opened this issue Aug 15, 2024 · 0 comments · Fixed by #1374
Assignees
@joroshiba
Labels
bug Something isn't working ci issues that are related to ci and github workflows

Comments

@joroshiba
Copy link
Member

joroshiba commented Aug 15, 2024 •
edited by sync-by-unito bot
Loading

Due to naming differences between rust package and our automated ci scripts evm-bridge-withdrawer not currently building at tag location

┆Issue Number: ENG-722
@joroshiba joroshiba self-assigned this Aug 15, 2024
@joroshiba joroshiba added bug Something isn't working ci issues that are related to ci and github workflows labels Aug 15, 2024
@joroshiba joroshiba mentioned this issue Aug 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
@joroshiba
fix(ci): enable bridge withdrawer building with tag (#1374)
a603923 
## Summary
Updates the image build to work on a specific tag when binary name and
image name don't match

## Background
The `astria-bridge-withdrawer` binary is pushed to an
`evm-bridge-withdrawer` docker package and the tag used is
`bridge-withdrawer-v<semantic version>` for releases. This is
potentially suboptimal but has already been done. Our image build script
doesn't work with this setup.

## Changes
- update image build to consider `binary-name` without `astria` prefix
and take a separate `package-name` for most instances these are the same
but for when they are not it supports it. There is also a
`binary-prefix` which can be set to provide more flexibility for the
future.

## Testing
CI/CD tests

## Related Issues

closes #1373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joroshiba joroshiba

Labels
bug Something isn't working ci issues that are related to ci and github workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): enable bridge withdrawer building with tag astriaorg/astria
1 participant
@joroshiba