Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create cometbft tx result event when rollup Deposit created #1440

Closed
joroshiba opened this issue Sep 3, 2024 · 0 comments · Fixed by #1447
Closed

create cometbft tx result event when rollup Deposit created #1440

joroshiba opened this issue Sep 3, 2024 · 0 comments · Fixed by #1447
Assignees
@ethanoroshiba
Labels
bridging sequencer pertaining to the astria-sequencer crate

Comments

@joroshiba
Copy link
Member

joroshiba commented Sep 3, 2024 •
edited by sync-by-unito bot
Loading

Right now we create the Deposit in the sequencer app but there is nothing in cometbft indicating this has occured. We should have a tx result event which contains the deposit associated with the tx.

┆Issue Number: ENG-772
@joroshiba joroshiba added sequencer pertaining to the astria-sequencer crate bridging labels Sep 3, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Sep 4, 2024
Merged
@ethanoroshiba ethanoroshiba linked a pull request Sep 5, 2024 that will close this issue
feat(sequencer): report deposit events #1447
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
@ethanoroshiba @joroshiba
@Fraser999 @steezeburger
feat(sequencer): report deposit events (#1447)
81f2931 
## Summary
Added creation of ABCI deposit events and record them to the state to be
included in `ExecTxResult`.

## Background
Deposit events were previously only stored app-side in `SequencerBlock`.
This will allow for outside observation of the deposit events.

## Changes
- Added helper function for the creation of ABCI deposit events.
- Added recording of these events whenever deposits are created.

## Testing
Added test to ensure deposit events are correctly recorded and returned
by `state.apply()`

## Related Issues
closes #1440

---------

Co-authored-by: Jordan Oroshiba <jordan@astria.org>
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Co-authored-by: jesse snyder <jessetsnyder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
bridging sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sequencer): report deposit events astriaorg/astria
2 participants
@joroshiba @ethanoroshiba