fix(sequencer)!: store native asset ibc->trace mapping in init_chain #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
reviewed
Jul 8, 2024
Comment on lines
+225
to
+232
| let native_asset = crate::asset::get_native_asset(); | ||
| if let Some(trace_native_asset) = native_asset.as_trace_prefixed() { | ||
| state_tx | ||
| .put_ibc_asset(trace_native_asset) | ||
| .context("failed to put native asset")?; | ||
| } else { | ||
| bail!("native asset must not be in ibc/<ID> form") | ||
| } |
There was a problem hiding this comment.
what's going on with indent here? it feels like there is a missing block here?
There was a problem hiding this comment.
The indent is actually fine - github code wrapping makes this look a bit weird if your window is too narrow.
There was a problem hiding this comment.
Oh wow that was cursed. dammit github
SuperFluffy
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
That was my oversight, thank you for fixing it.
I actually want to get rid of these globals (meaning the native asset one here and the base address prefix), and instead have a new StateExt where these are read everytime they are needed.
I believe this should have a negligible impact on performance, makes testing easier, and would avoid errors such this one.
Comment on lines
+225
to
+232
| let native_asset = crate::asset::get_native_asset(); | ||
| if let Some(trace_native_asset) = native_asset.as_trace_prefixed() { | ||
| state_tx | ||
| .put_ibc_asset(trace_native_asset) | ||
| .context("failed to put native asset")?; | ||
| } else { | ||
| bail!("native asset must not be in ibc/<ID> form") | ||
| } |
There was a problem hiding this comment.
The indent is actually fine - github code wrapping makes this look a bit weird if your window is too narrow.
SuperFluffy
changed the title
|
Added an exclamation mark, as in |
steezeburger
added a commit
that referenced
this pull request
Jul 15, 2024
* main: feat(cli): add cmd to collect withdrawal events and submit as actions (#1261) fix(core, bridge, sequencer)!: dismabiguate return addresses (#1266) fix(withdrawer): support withdrawer address that differs from bridge address (#1262) (core, sequencer)!: generate serde traits impls for all protocol protobufs (#1260) fix(charts): add resources for sequencer/cometbft (#1254) chore(sequencer)!: add metrics (#1248) fix(sequencer-utils): fixes issue in `parse_blob` tests (#1243) feat(core, proto)!: make bridge unlock memo string (#1244) fix(conductor): don't panic during panic (#1252) feat(core)!: lowerCamelCase for protobuf json mapping (#1250) refactor(bridge-withdrawer)!: refactor startup to a separate subtask and remove balance check from startup (#1190) fix: rollup archive node configurations (#1249) refactor(core, bridge-withdrawer)!: move bridge-unlock memo to core (#1245) fix(sequencer)!: store native asset ibc->trace mapping in init_chain (#1242)
bharath-123
pushed a commit
that referenced
this pull request
Jul 25, 2024
…1242) ## Summary we need to store the native asset ibc to "trace" mapping in the state, otherwise queries for the native asset using the ID will fail. for example `get_bridge_account_info` where the asset is the native asset fails right now ## Changes - store native asset ibc->trace mapping in `init_chain` - also enforce that the native asset is is "trace" form, as otherwise, we won't be able to map from ibc->trace form for the asset as we don't know the trace form. ## Breaking changes - this is unfortunately breaking since the ibc->trace mapping is stored in app state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
we need to store the native asset ibc to "trace" mapping in the state, otherwise queries for the native asset using the ID will fail. for example
get_bridge_account_infowhere the asset is the native asset fails right nowChanges
init_chainBreaking changes