chore(bridge-withdrawer): cleanup nonce handling #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this truly a breaking change? The PR title contains a |
SuperFluffy
changed the title
ethanoroshiba
changed the title
Certainly not, wasn't up to speed on labeling so thanks for the correction! |
Fraser999
reviewed
Jul 29, 2024
crates/astria-bridge-withdrawer/src/bridge_withdrawer/submitter/mod.rs
Outdated
Show resolved
Hide resolved
crates/astria-bridge-withdrawer/src/bridge_withdrawer/submitter/mod.rs
Outdated
Show resolved
Hide resolved
github-actions
bot
added
documentation
ethanoroshiba
force-pushed
the
eoroshiba/deduplicate_pending_nonce
branch
from
ab37180 to
6a7cb1c
Compare
ethanoroshiba
removed
documentation
ethanoroshiba
added
bridge-withdrawer
Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Fraser999
approved these changes
Jul 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
steezeburger
added a commit
that referenced
this pull request
Aug 2, 2024
* main: chore(core): Implement Protobuf trait for tx actions (#1320) refactor(sequencer): remove global state (#1317) refactor(sequencer): move asset state methods to asset module (#1313) feat(sequencer, core): Add fee reporting (#1305) chore(bridge-withdrawer): cleanup nonce handling (#1292) fix(charts, bridge): fix ci test (#1310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicated and added metrics to
get_pending_nonce(), fixed too many arguments inprocess_batch().Background
Following #1215,
get_pending_nonce()was present in both the bridge-withdrawer and submitter, in which the submitter'sget_pending_nonce()also did not implement metrics. The submitter'sprocess_batch()function also had a Clippy exception for too many arguments.Changes
bridge_withdrawer/startup.rs: get_pending_nonce()and its helper functionmake_sequencer_grpc_retry_config.submitter/mod.rs: get_pending_nonce()and formatted accordingly.get_pending_nonce()to allow for it to be used in the bridge-withdrawer startup.get_pending_nonce(), as well as mutators withinMetrics.process_batch()insideSubmitterto allow for sharing of members between the two, cutting down arguments and removing Clippy exception.Testing
Passes blackbox tests.
Metrics
nonce_fetch_count.nonce_fetch_failure_count.nonce_fetch_latency.Related Issues
Closes #1272
Closes #1273
Closes #1274