feat(cli): implement frost_ed25519 threshold signing cli #1654
Conversation
| struct PrepareMessage { | ||
| /// message to be signed | ||
| #[arg(long)] | ||
| message: String, |
There was a problem hiding this comment.
Do we need something that is not a string for the message?
This message is generally going to be the transaction we are signing right? At some point it needs to become a protobuf serialized TransactionBody (formerly UnsignedTransaction)?
In the simplest form we could have a message which is just pbjson via a file read? Then we might want to add a way to generate txs without signing and output the pbjson form of them, but not that's more better ux, we could generate that ourselves relatively simply?
There was a problem hiding this comment.
updated this to take a file that contains the message bytes. I could add an option to deserialize the message as a TransactionBody and display that before signing?
This message is generally going to be the transaction we are signing right?
yes, I was thinking of updating the other CLI commands to have an option to output the TransactionBody into a file, which is then used as the input to this command.
I also updated aggregate to have an option to output the signed message as a Transaction (signed) that can then be submitted to the sequencer.
| --signing-package-path signing_package.out | ||
| ``` | ||
|
|
||
| The output is an ed25510 signature, eg: |
There was a problem hiding this comment.
| The output is an ed25510 signature, eg: | |
| The output is an ed25519 signature, eg: |
Summary
implement threshold signing cli using the frost_ed25519 library.
Background
can be used for turning sequencer accounts into multisigs without any changes to the sequencer itself.
Changes
dkg,sign, andverifycommandsTesting
i ran it manually and verified the signature.
Related Issues
closes #833