fix(bridge-withdrawer): check if base denom is usdc to determine when to use compat address #1671
Conversation
There was a problem hiding this comment.
I think astria-bridge-contracts is the wrong place to decide if the compat address should be used or not. For one, what if there are other denominations that require a compat address? Also, what if I want to send wrapped usdc to another chain that is not noble (and capable of dealing with bech32m)?
The contracts crate should allow specifying compatibility mode, but through its builder not via a heuristic.
Instead, let's move this check to astria-bridge-withdrawer - and provide a new flag for the astria-cli bridge collect-withdrawals subcommand.
| // | ||
| // since we're always unwrapping the asset (sending back to the originating chain), we | ||
| // can check that the base denom is USDC, and if it is, we know we're sending to Noble. | ||
| use_compat_address = ics20_asset_to_withdraw.base_denom() == "usdc"; |
There was a problem hiding this comment.
Instead of hardcoding this here, I'd prefer to add a method fn use_compat_address(self, use_compat_address: bool) -> Self on the builder and let the user of this crate decide if they want compat or not.
Summary
check if base denom is usdc to determine when to use compat address as the sender/return address.
Background
required for if the withdrawal to noble times out/fails
Changes
use_compat_addressto true, false otherwise.Testing
existing unit tests, would need to have a withdrawal timeout test for noble to fully test this
Related Issues
closes #1424