chore(core, sequencer): add names to all snapshot tests #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conductor
ethanoroshiba
added
code-quality
testing
and removed
conductor
ethanoroshiba
force-pushed
the
ENG-916/snapshot_names
branch
from
7c9041a to
a72de80
Compare
ethanoroshiba
changed the title
ethanoroshiba
requested review from
a team,
joroshiba,
SuperFluffy and
noot
as code owners
noot
approved these changes
Oct 29, 2024
SuperFluffy
approved these changes
Oct 29, 2024
...stria-core/src/primitive/v1/snapshots/astria_core__primitive__v1__tests__compat_address.snap
Outdated
Show resolved
Hide resolved
| @@ -845,15 +845,15 @@ mod tests { | |||
| .prefix(ASTRIA_ADDRESS_PREFIX) | |||
| .try_build() | |||
| .unwrap(); | |||
| insta::assert_json_snapshot!(&main_address.to_raw()); | |||
| insta::assert_json_snapshot!("main_address", &main_address.to_raw()); | |||
There was a problem hiding this comment.
Let's never name this main_bech32m_address
There was a problem hiding this comment.
I'm assuming you meant to name it main_bech32m_address?
joroshiba
approved these changes
Dec 6, 2024
ethanoroshiba
added a commit
that referenced
this pull request
Dec 6, 2024
## Summary Added names to all snapshot tests which did not have them. ## Background If a certain test had multiple snapshot assertions, they would be named based on their ordering. Hence any reordering, removal, or addition of the snapshots would break the test, which should not be the case. This change aims to fix this problem as well as establish a best practice of naming snapshots moving forward. ## Changes - Added names to all snapshot tests and regenerated all snapshots not within Conductor (due to code freeze) ## Testing Passing all tests. ## Related Issues closes #1656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added names to all snapshot tests which did not have them.
Background
If a certain test had multiple snapshot assertions, they would be named based on their ordering. Hence any reordering, removal, or addition of the snapshots would break the test, which should not be the case. This change aims to fix this problem as well as establish a best practice of naming snapshots moving forward.
Changes
Testing
Passing all tests.
Related Issues
closes #1656