-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sequencer): add instrumentation #1761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this for now (as much a reminder to myself as anything else).
Discussed offline with @ethanoroshiba that this will be revisited to ensure we're only using error-level instrumentation where it's warranted (i.e. where it indicates a serious problem or bug in the logic) and not for non-critical cases (e.g. handling a malformed client request).
Summary
Added instrumentation to most async functions which did not have it.
Background
Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.
Changes
err
argument to theinstrument
macro where applicable.instrument
macro where applicable.Testing
Passing all tests.
Changelogs
No updates required
Related Issues
closes #1321