Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sequencer): remove references to outdated ABCI methods #1826

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore(sequencer): remove references to outdated ABCI methods #1826

wants to merge 12 commits into from

Conversation

ethanoroshiba
Copy link
Contributor

@ethanoroshiba ethanoroshiba commented Nov 19, 2024 •
edited
Loading

Summary

Renamed begin_block and end_block and replaced their arguments with our own types.

Background

The ABCI methods begin_block and end_block, as well as their associated types, were removed as of v0.38. While it is useful for us to have start and end of block hooks for our components to make changes to the state, we should stop using outdated methods and types.

Changes

  • Renamed begin_block to prepare_state_for_tx_execution.
  • Renamed end_block to handle_post_tx_execution.
  • Replaced BeginBlock with proprietary type PrepareStateInfo.
  • Removed EndBlock as an argument, since it was not needed.
  • Moved fee payment to sudo address into fees component.

Testing

Passing all tests.

Changelogs

No updates needed, I don't think.

Related Issues

closes #1809

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Nov 19, 2024
@ethanoroshiba ethanoroshiba force-pushed the ENG-1006/begin_and_end_block branch from cdda4c7 to 1662c72 Compare November 19, 2024 22:12
@ethanoroshiba ethanoroshiba changed the title chore(sequencer): remove references to outdated ABCI methods and structs chore(sequencer): remove references to outdated ABCI methods Nov 20, 2024
@ethanoroshiba ethanoroshiba marked this pull request as ready for review November 20, 2024 15:07
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner November 20, 2024 15:07
@ethanoroshiba ethanoroshiba requested review from a team and joroshiba as code owners December 5, 2024 21:00
@github-actions github-actions bot added documentation Improvements or additions to documentation conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer cd labels Dec 5, 2024
@ethanoroshiba ethanoroshiba force-pushed the ENG-1006/begin_and_end_block branch from 8b10b28 to 0629d4f Compare December 5, 2024 21:03
@ethanoroshiba ethanoroshiba removed documentation Improvements or additions to documentation conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer cd labels Dec 5, 2024
@ethanoroshiba ethanoroshiba removed request for a team and joroshiba December 5, 2024 21:29
Base automatically changed from ENG-995/refactor_sequencer_app to main December 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot left review comments

@SuperFluffy SuperFluffy Awaiting requested review from SuperFluffy SuperFluffy is a code owner automatically assigned from astriaorg/rust-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanoroshiba @noot