Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update rust lint workflows and just recipes #1871

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

ethanoroshiba
Copy link
Contributor

@ethanoroshiba ethanoroshiba commented Dec 11, 2024

Summary

Moved rust lints to just recipes, added all to lint rust recipe.

Background

Discrepancies between the just recipe and GH workflow made it so that the lint command might succeed but then fail when a PR is opened. This is meant to make it easier to match the GH workflow locally and test to ensure this status check will pass.

Changes

  • Moved all rust lints to just recipes.
  • Changed _lint-rust to call all of the above recipes.

Testing

Manually tested

Changelogs

No updates required

@ethanoroshiba ethanoroshiba marked this pull request as ready for review December 11, 2024 16:31
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner December 11, 2024 16:31
@ethanoroshiba ethanoroshiba requested a review from noot December 11, 2024 16:31
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner December 11, 2024 19:37
@github-actions github-actions bot added the ci issues that are related to ci and github workflows label Dec 11, 2024
@ethanoroshiba ethanoroshiba changed the title chore: update just lint rust recipe chore(ci): update rust lint workflows and just recipes Dec 11, 2024
Copy link
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great keeping this in sync with single source 👍

@ethanoroshiba ethanoroshiba added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit bc2569a Dec 16, 2024
49 checks passed
@ethanoroshiba ethanoroshiba deleted the eoroshiba/update_just_lint branch December 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues that are related to ci and github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants