feat(sequencer): implement oracle module actions #1878
Conversation
github-actions
bot
added
proto
| @@ -55,6 +57,9 @@ impl_belong_to_group!( | |||
| (FeeAssetChange, Group::BundleableSudo), | |||
| (IbcRelay, Group::BundleableGeneral), | |||
| (IbcSudoChange, Group::UnbundleableSudo), | |||
| // TODO: should these have a different group? | |||
There was a problem hiding this comment.
Do we have an answer for this?
There was a problem hiding this comment.
I think BundleableGeneral is correct, as it's an action that's ok to be bundled and isn't a sudo-action (but it is a permissioned action, just not sent by the sudo address)
There was a problem hiding this comment.
the other option is to make a new BundleableMarketMapAdmin group, but not sure that's really necessary
There was a problem hiding this comment.
I can't think of any problem in using BundleableGeneral either. Happy to not add a new group if we don't really need to :)
There was a problem hiding this comment.
I guess this TODO line should be deleted pls.
crates/astria-sequencer/src/action_handler/impls/add_currency_pairs.rs
Outdated
Show resolved
Hide resolved
crates/astria-sequencer/src/action_handler/impls/add_currency_pairs.rs
Outdated
Show resolved
Hide resolved
crates/astria-sequencer/src/action_handler/impls/add_currency_pairs.rs
Outdated
Show resolved
Hide resolved
crates/astria-sequencer/src/action_handler/impls/remove_currency_pairs.rs
Outdated
Show resolved
Hide resolved
crates/astria-sequencer/src/action_handler/impls/remove_currency_pairs.rs
Outdated
Show resolved
Hide resolved
crates/astria-sequencer/src/action_handler/impls/remove_currency_pairs.rs
Outdated
Show resolved
Hide resolved
crates/astria-sequencer/src/action_handler/impls/remove_currency_pairs.rs
Show resolved
Hide resolved
| @@ -30,6 +31,10 @@ message Action { | |||
| FeeAssetChange fee_asset_change = 53; | |||
| FeeChange fee_change = 55; | |||
| IbcSudoChange ibc_sudo_change = 56; | |||
|
|
|||
| // Oracle actions are defined on 61-70 | |||
There was a problem hiding this comment.
Do you think we should start this range at 71 or even higher to leave plenty of room for other sudo actions in the future?
There was a problem hiding this comment.
yeah, doesn't hurt, i will change
Summary
implement oracle module actions
AddCurrencyPairandRemoveCurrencyPairsee https://github.com/skip-mev/connect/blob/main/proto/connect/oracle/v2/tx.proto and https://github.com/skip-mev/connect/blob/9ea31680774e2f71e683c0a4989df5bf2d5f2302/x/oracle/keeper/msg_server.go#L28 for relevant connect code
Background
these are required for the oracle authorities to be able to add/remove currency pairs from state; these are the pairs whose prices will be included in VEs.
Changes
AddCurrencyPairandRemoveCurrencyPairCurrencyPairState.QuotePriceoptional, to reflect that this may not be set upon currency pair initialization (as no oracle price has been received for it)get/put_num_removed_currency_pairsfrom the oracle state_ext as it's not needed for our logic due to the fact that we execute txs in the proposal phase, so by the time vote extensions are issued for a block, the state has already been updated and currency pairs that are removed in that block have already been removed.Testing
unit tests
Breaking Changelist
Related Issues
part of # #1446