use latest for queries packet/ack/receipt and return proof height #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am concerned that many of the Rust CI tests fail. |
|
@SuperFluffy they fail on the main branch 😭 started #20 to attempt to fix. we won't be shipping this fix as of now as the packet indexing actually fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix for hermes querying old states in astria that are no longer stored. updates hermes to query at the latest height, and use the proof height returned in the response to know what height the proof is for.
testing by running the ibc-test in astria monorepo with image
hermes:sha-a3899e7