Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DRAGONS notebooks [DRAGONS-3.2.1 (Py3.10)] #249

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Updated DRAGONS notebooks [DRAGONS-3.2.1 (Py3.10)] #249

merged 2 commits into from
Sep 17, 2024

Conversation

bmerino95
Copy link
Contributor

Hi @rnikutta and @jacquesalice! If you have time, can you review these notebooks for me?

Changes to notebooks:

  1. Tested all seven notebooks on the new kernel DRAGONS-3.2.1 (Py3.10)
  2. All notebooks now contain a 'clean up' function that removes fits files and calibration directories to avoid running DRAGONS on files that have already been processed.
  3. The 'Adapted from' link at the beginning of each notebook (except for GMOS Imaging Galaxy*) has been updated.

*The GMOS Imaging tutorial on which my notebook is based has been replaced, so there is no updated link.

@bmerino95 bmerino95 added the enhancement New feature or request label Sep 13, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rnikutta
rnikutta approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@rnikutta rnikutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All NBs run fine. Tested all via NB test suite, and one also solo. New clean-up function is neat! Thanks @bmerino95 !

jacquesalice
jacquesalice approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@jacquesalice jacquesalice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@bmerino95
Copy link
Contributor Author

Thank you, @rnikutta and @jacquesalice! I'll go ahead and merge the pull request.

@bmerino95 bmerino95 merged commit a579c78 into master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesalice jacquesalice jacquesalice approved these changes

@rnikutta rnikutta rnikutta approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmerino95 @rnikutta @jacquesalice