Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reality symmetry (hermitian symmetry) #129

Merged
merged 11 commits into from
Dec 7, 2022
Merged

Conversation

CosmoMatt
Copy link
Collaborator

@CosmoMatt CosmoMatt commented Dec 6, 2022

This PR adds support for real signals, e.g. Hermitian symmetry. This includes adding support for

  • Real forward transforms
    • mw
    • mwss
    • dh
    • healpix
  • Real inverse transforms
    • mw
    • mwss
    • dh
    • healpix

Currently this PR updates transforms to accelerate evaluation but does not change memory overhead. A further factor of 2 saving in memory could be achieved at the cost of slightly more opaque indexing to arrays. Finally, adding support for real signals within single transforms is getting somewhat cluttered, but perhaps this is ok?

@CosmoMatt CosmoMatt requested a review from jasonmcewen December 6, 2022 13:19
@CosmoMatt CosmoMatt self-assigned this Dec 6, 2022
@CosmoMatt CosmoMatt added the enhancement New feature or request label Dec 6, 2022
@CosmoMatt
Copy link
Collaborator Author

CosmoMatt commented Dec 6, 2022

@jasonmcewen currently reality is also supported for healpix sampling, but given the extra caveats around the healpix_ffts switching from complex to real FFTs is probably not worth chopping up the code. Especially as we're doing SOV so the compute time, which is additive, is dominated by the primary loop not the FFTs.

If you think that's ok then we can tick off healpix support and get this merged.

@jasonmcewen
Copy link
Contributor

jasonmcewen commented Dec 7, 2022

Looks great @CosmoMatt, as discussed. Let's merge this and consider Healpix in another PR.

@jasonmcewen jasonmcewen merged commit e942ffb into main Dec 7, 2022
@jasonmcewen jasonmcewen deleted the feature/reality branch December 7, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants