Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping/clean code up #78

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Housekeeping/clean code up #78

merged 8 commits into from
Apr 9, 2024

Conversation

CosmoMatt
Copy link
Collaborator

@CosmoMatt CosmoMatt commented Mar 8, 2024

Scope crept quite a lot on this but still effectively housekeeping.
Main contributions:

Housekeeping

  • Restructure code to be more consistant.
  • Update api docs inline with above.
  • Clean floating files (notebooks from previous work)
  • Combine tests into one overloaded pytest function.
  • Switch s2fft dependency to v1.0.2

Added features

  • Add switch to avoid duplicating highest wavelet scale memory.
  • Pull through support for Torch frontend and test
  • Add Torch support to all docs and api autodocs
  • Pull through support for Gauss-Legendre (GL) sample locations
  • Add torch notebook and update across the board

C backend support for SSHT operations

  • port through JAX frontend support for C backend.

CI related

  • Enhance codecov to > 90%

@CosmoMatt CosmoMatt self-assigned this Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 91.53005% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 91.99%. Comparing base (c5702aa) to head (6394602).

Files Patch % Lines
s2wav/filters.py 88.10% 22 Missing ⚠️
s2wav/transforms/wavelet_precompute_torch.py 92.30% 4 Missing ⚠️
s2wav/samples.py 91.66% 2 Missing ⚠️
s2wav/transforms/wavelet.py 93.93% 2 Missing ⚠️
s2wav/transforms/construct.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   88.31%   91.99%   +3.67%     
==========================================
  Files           8        7       -1     
  Lines         522      587      +65     
==========================================
+ Hits          461      540      +79     
+ Misses         61       47      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonmcewen jasonmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @matt. I've approved so you can merge.

At some point we should avoid this notebook links and use the better approach we're now following for s2fft. If you prefer not to do this now could you make an issue so we don't forget.

@CosmoMatt
Copy link
Collaborator Author

@jasonmcewen I'm not sure I follow. What notebook links do you mean?

@jasonmcewen
Copy link
Contributor

@CosmoMatt There appear to be nblink files in the repo? Remember we chances how the notebooks were set up for colab support in s2fft?

@CosmoMatt CosmoMatt merged commit 50622a4 into main Apr 9, 2024
3 checks passed
@CosmoMatt CosmoMatt deleted the housekeeping/clean_code_up branch April 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants