-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping/clean code up #78
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 88.31% 91.99% +3.67%
==========================================
Files 8 7 -1
Lines 522 587 +65
==========================================
+ Hits 461 540 +79
+ Misses 61 47 -14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @matt. I've approved so you can merge.
At some point we should avoid this notebook links and use the better approach we're now following for s2fft
. If you prefer not to do this now could you make an issue so we don't forget.
@jasonmcewen I'm not sure I follow. What notebook links do you mean? |
@CosmoMatt There appear to be nblink files in the repo? Remember we chances how the notebooks were set up for colab support in s2fft? |
Scope crept quite a lot on this but still effectively housekeeping.
Main contributions:
Housekeeping
s2fft
dependency tov1.0.2
Added features
C backend support for SSHT operations
CI related