Mm/onnx parameter tweaks #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmcleod89
commented
Nov 21, 2024
•
mmcleod89
commented
- Set the step size correctly for onnx model and standard l2-norm gradient
- Replace vague greek letters with descriptive names
added 14 commits
November 13, 2024 11:37
added 11 commits
November 21, 2024 13:21
…cs/sopt into mm/onnx_parameter_tweaks
20DM
approved these changes
Nov 22, 2024
cpp/sopt/differentiable_func.h
Outdated
| @@ -34,6 +34,16 @@ template <typename SCALAR> class DifferentiableFunc | |||
| // Calculate the function directly | |||
| virtual Real function(t_Vector const &image, t_Vector const &y, t_LinearTransform const &Phi) = 0; | |||
|
|
|||
| // Get appropriate gradient step-size for FISTA algorithms | |||
| Real get_step_size() | |||
There was a problem hiding this comment.
Consider making this method const?
cpp/sopt/onnx_differentiable_func.h
Outdated
| SOPT_MEDIUM_LOG("Lipschitz Constant for CRR = {}", L_CRR); | ||
| SOPT_MEDIUM_LOG("Step size for CRR = {}", this->step_size); | ||
| } | ||
| catch(std::exception e) |
There was a problem hiding this comment.
consider passing the exception by const ref?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.