-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new packages.${system}.default convention #195
Conversation
Sorry, while waiting for the checks to pass I learned that The diff view can be simplified by surpressing whitespace diff. |
Happy to catch up with There is no |
flake-template/flake.nix
Outdated
source = "/nix/store"; | ||
mountPoint = "/nix/.ro-store"; | ||
} ]; | ||
nixosConfiguration = nixpkgs.lib.nixosSystem { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right? Shouldn't it be nixosConfigurations.my-microvm =
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, yes. This PR needs changes.
@thkoch2001 Are you going to do that?
The switch from defaultPackage to packages.${system}.default happened in NixOS/nix#5532.
Sorry for the double-push. I reduced the commit now to the trivial one-line change. In my own local flake however I removed nixosConfigurations entirely from the flake:
|
Thank you! |
The switch from defaultPackage to packages.${system}.default happened in NixOS/nix#5532.
Additionally I removed one layer:
self.nixosConfigurations.my-microvm.config.microvm.declaredRunner; self.nixosConfiguration.config.microvm.declaredRunner;
The latter should be easier to understand for new users.