Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Radial_Velocity table #69

Open
kelle opened this issue Jul 1, 2024 · 3 comments
Open

Add Radial_Velocity table #69

kelle opened this issue Jul 1, 2024 · 3 comments
Labels

Comments

@kelle
Copy link
Contributor

kelle commented Jul 1, 2024

We have an ingest_radial_velocity function ready to go. Let's add the table!

@arjunsavel
Copy link
Collaborator

@kelle Don't we already have some example quantity tables? My gut feeling is that not everyone would have radial velocities in their own databse.

@kelle
Copy link
Contributor Author

kelle commented Aug 1, 2024

Hmm, this raises a good topic which I don't think we've discussed explicitly recently -- how do we want to decide what tables to include in the template. At the moment, I'm inclined to include more tables than less...it's easier for a user to remove/modify tables than it is to make up their own from scratch. The more tables we have defined, the more likely databases will be compatible with each other. For example, I think it would make sense for the template to have both a radial velocity AND redshift table.

@kelle
Copy link
Contributor Author

kelle commented Dec 10, 2024

Partially addressed by #86 . Still will need to add tests from #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants