Add radial velocities table #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelle
reviewed
Aug 14, 2024
tests/test_schema.py
Outdated
| ({"radial_velocity_km_s": None}, ValueError), | ||
| ({"radial_velocity_error_km_s": None}, None), | ||
| ({"radial_velocity_error_km_s": 30}, None), | ||
| ({"radial_velocity_error_km_s": -30}, None), |
There was a problem hiding this comment.
Should the uncertainty be allowed to be negative?
There was a problem hiding this comment.
Yeah I guess not! I was thinking about the "negative parallaxes are not unexpected" Gaia results, and I must've mixed them up with errors. I can fix this for parallaxes and RVs.
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
|
add |
|
add a module for testing this table — at min check the counts in the table |
|
The table is being added in #86 . But we'll still need the tests from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #69.
Follows the same procedure as adding the parallax table. add the quantity, its error, some validators, some schema tests.
Tried to correspond to the ingest script: astrodbtoolkit/astrodb_utils#52