Skip to content

Conversation

kelle
Copy link
Contributor

@kelle kelle commented Mar 10, 2025

@kelle kelle marked this pull request as draft March 10, 2025 15:12
This was linked to issues Mar 10, 2025
@kelle kelle marked this pull request as ready for review March 10, 2025 22:13
@kelle kelle requested a review from dr-rodriguez March 10, 2025 22:13
Comment on lines 230 to 233
source,
*,
reference: str = None,
*,
ra: float = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the point of * in the args to enforce explicit use of keyword arguments? So shouldn't it remain above reference?

@kelle kelle merged commit 21e8910 into astrodbtoolkit:main Mar 11, 2025
3 checks passed
@kelle kelle deleted the no-fuzzy branch March 11, 2025 20:28
@kelle kelle linked an issue Mar 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in ingest_source Problem with ingest_publication Issue with ingest publications function
2 participants