Adding fuzzy=false to find_source_in_db and use in ingest_source
#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 10, 2025
Closed
Comment on lines
230
to
233
| source, | ||
| *, | ||
| reference: str = None, | ||
| *, | ||
| ra: float = None, |
There was a problem hiding this comment.
Isn't the point of * in the args to enforce explicit use of keyword arguments? So shouldn't it remain above reference?
dr-rodriguez
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find_source_in_dbis finding too many things and needs afuzzy=falseoption. add fuzzy=False option infind_source_in_db#115ingest_sourcenow works better since default is fuzzy=false in find_source_in_dbingest_publicationProblem withingest_publication#106