fix arxiv_id bug in ingest_publication #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-rodriguez
reviewed
Apr 8, 2025
dr-rodriguez
reviewed
Apr 8, 2025
|
Is there an associated ticket with the bug? Just wondering if there is an explicit example and any additional notes/information. |
dr-rodriguez
reviewed
Apr 8, 2025
|
In addition to the arxix_id bug, I was also responding to Ruff letting me know the function was too complex. |
| ) | ||
| return | ||
|
|
||
| if reference and not bibcode and not doi: |
There was a problem hiding this comment.
In general, I recommend if statements be explicit unless they are booleans already. Neither reference, bibcode, or doi are booleans so you would want to use things like if reference is not None instead of just if reference
| name_add = reference | ||
| using = f"ref: {reference} user input. No bibcode or DOI provided." | ||
|
|
||
| if ignore_ads is False and check_ads_token() is False: |
There was a problem hiding this comment.
Here, I would have done the opposite since these are booleans: if not ignore_ads and not check_ads_token()
dr-rodriguez
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug in
ingest_publicationwhen only an arxiv-id was provided. Adds relevant tests.