Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21 - Test lib code-actions #39

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 2, 2024

Solves #21

@0xSwapFeeder 0xSwapFeeder force-pushed the chore/18-unit-testing/21-test-lib-code-actions-staging branch from 08c8953 to 047b420 Compare May 12, 2024 22:48
@0xSwapFeeder 0xSwapFeeder marked this pull request as ready for review June 26, 2024 13:37
@0xmemorygrinder 0xmemorygrinder force-pushed the chore/18-unit-testing/21-test-lib-code-actions-staging branch from 2ac0cf2 to 35e6207 Compare July 2, 2024 04:31
Copy link
Contributor

@0xmemorygrinder 0xmemorygrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@@ -2,6 +2,7 @@ mod code_actions_provider;
mod completions;
mod error;
mod references;
mod test_utils;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this module could be declared only on test runs (check rust macros for that) in order to remove all the "#[allow(dead_code)] everywhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow dead code could be removed if you declare this file only on test runs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed

@0xSwapFeeder 0xSwapFeeder merged commit c050de4 into chore/18-unit-testing-staging Sep 16, 2024
5 of 9 checks passed
@ByFishh ByFishh deleted the chore/18-unit-testing/21-test-lib-code-actions-staging branch October 9, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants