Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 - Refactoring #8

Merged
merged 10 commits into from
Mar 28, 2024
Merged

5 - Refactoring #8

merged 10 commits into from
Mar 28, 2024

Conversation

0xmemorygrinder
Copy link
Contributor

Solves #5

@0xmemorygrinder 0xmemorygrinder linked an issue Mar 26, 2024 that may be closed by this pull request
4 tasks
@0xmemorygrinder 0xmemorygrinder removed a link to an issue Mar 26, 2024
4 tasks
@0xmemorygrinder 0xmemorygrinder linked an issue Mar 26, 2024 that may be closed by this pull request
4 tasks
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions but overall looks good

remove-me-37f74ae488514ffb9c20.txt Outdated Show resolved Hide resolved
servers/references-server/src/main.rs Show resolved Hide resolved
servers/tests-positions-server/src/main.rs Show resolved Hide resolved
turbo.json Show resolved Hide resolved
@0xtekgrinder 0xtekgrinder self-requested a review March 27, 2024 21:07
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmemorygrinder 0xmemorygrinder merged commit 7c6757e into dev Mar 28, 2024
13 of 14 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the chore/5-refactoring-staging branch March 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring
2 participants